qr-code-component-main

Community feedback

• 

  Baki Jessy Justice Julien•110

  @blackdreamer15Posted over 2 years ago

  Hi @urrrch! Congratulations on completing this challenge. I checked your code on GitHub and have some suggestions to make.

  1. You have to use a <h1> tag instead of a <h4> tag to resolve one of the accessibility issues. Conventionally, you have to start with a level-one heading. (that is, the h1 tag)

  2. For the semantic reasons, it will be best to change <div class="content"></div> to <main class="content"></main> since it contains the main content of the page.

  3. I think the <div class="wrapper"></div> is not really important since you can apply the styles directly to the <main class="content"></div>.

  4. Also, you can increase the dimensions of the container and its items to make the whole QR code component a bit bigger.

  5. You can also add some padding to the content to add some spaces between them.

  Good luck with your other challenges.

  0

  ---

  

  Barbie_Dev•30

  @urrrchPosted over 2 years ago

  @blackdreamer15 thank you very much.

  0

  

  Baki Jessy Justice Julien•110

  @blackdreamer15Posted over 2 years ago

  You're welcome, @urrrch.

  0