qr-code-component-main

Community feedback

• 

  Adriano•38,330

  @AdrianoEscarabotePosted almost 2 years ago

  Hi sohail mahmoud, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  As you know this page is just a component, so it doesn't even need an h1! because we don't know how important the other components of the site will be! but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1.

  <h1>Improve your front-end skills by building projects</h1>

  To improve the responsiveness of the project, we can do this:

  main h2 {
      max-width: 300px;
  }
  main p {
      max-width: 250px;
  }
  

  The rest is great!

  I hope it helps... 👍

  0

  ---

  

  sohail mahmoud•260

  @sohailmahmoud17Posted almost 2 years ago

  @AdrianoEscarabote thanks, pal. I'll do it again

  1

  

  Adriano•38,330

  @AdrianoEscarabotePosted almost 2 years ago

  @sohailmahmoud17 happy coding!!

  0