Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-component-main

@sohailmahmoud17

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


welcome, If you saw the solution of the design, please tell me what should I do better than I did. thanks

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hi sohail mahmoud, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

As you know this page is just a component, so it doesn't even need an h1! because we don't know how important the other components of the site will be! but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1.

<h1>Improve your front-end skills by building projects</h1>

To improve the responsiveness of the project, we can do this:

main h2 {
    max-width: 300px;
}
main p {
    max-width: 250px;
}

The rest is great!

I hope it helps... 👍

0

@sohailmahmoud17

Posted

@AdrianoEscarabote thanks, pal. I'll do it again

1
Adriano 34,090

@AdrianoEscarabote

Posted

@sohailmahmoud17 happy coding!!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord