Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hi @sagarboyal 👋, good job completing this challenge! 🎉
I like this solution for the challenge. I have some suggestions you might consider to improve your code:
- Use the
<main>tag to wrap all the main content in your solution instead of using<div class="container">.
- Use
<footer>instead of<div class="attribution">. The<footer>element contains authorship information.
- In this challenge, the picture tag is not needed, since the image does not need to change depending on the viewport. This is necessary with the "Product preview card component" solution because the platform provides two images, one for mobile and one for desktop. You can directly use the image tag in this solution.
- The
<article>tag specifies independent content. The content of the article tag makes sense on its own and you can put that same article on a separate page and still make sense. You can use <div> instead.
- The alternative text must not contain hyphens, underscores, or the words "image" or "photo", it must be human readable.
- To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.
Above all, the project is done well👏. I hope those tips will help you! 👍
Good job, and happy coding! 😁
Marked as helpful
1
Sagar Boyal• 20
@sagarboyal
Posted
@MelvinAguilar ohoo!! I get it thank you 😊💕
1
