QR-code-component-main

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 8 months ago

  Hello @Mahendran-C!

  Your solution looks excelent!

  I have just one suggestion:

  📌 To improve semantic clarity, opt for <h1> over <h3> for your main title.

  It's more than just text size — it's about structuring your content effectively:

  • <h1> to <h6> are used to define HTML headings, with <h1> being the most significant.
  • Stick to one <h1> per page for the main title, and maintain the titles hierarchy with <h1>, <h2> <h3>, and so on.

  While these adjustments might not alter the visual appearance much, they significantly enhance semantic clarity, SEO optimization, and accessibility.

  Hope this suggestion proves helpful! Keep up the great work!

  Marked as helpful

  2

  ---

  

  Mahendran-C•130

  @Mahendran-CPosted 8 months ago

  Thanks for your feedback @danielmrz-dev

  1
• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 8 months ago

  HTML:

  • Remove figure, it should be used when you have a <figcaption>, .i.e text under the image.

  • The alt text should be written naturally, without using - between the words. The alt text must also say where it leads(frontendmentor.io).

  • Headings should always be in order, so you never start with a <h3>. Change it into a <h1>.

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Remove the properties on main to body. Add flex-direction: column, gap: 2rem, and change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove all widths and heights in px.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, remove the margin, and add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

  • I would double the padding on the card, from 8px to 16px.

  Marked as helpful

  1

  ---

  

  Mahendran-C•130

  @Mahendran-CPosted 8 months ago

  Thanks for your feedback @Islandstone89

  1