qr-code-component-main

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hey Makram, congratulations on completing the challenge! You did a great job 😉

  Let me give you some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • to make it look as close to the design as possible add width: 20rem to .card-container class
  • add width: 100% to img element
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😁

  0

  ---

  

  Makram M Ibrahim•130

  @pharaohmakPosted over 2 years ago

  @denielden thank you for your response! I really appreciate the advice, very helpful!

  1