Skip to content
Submitted about 2 years ago

qr-code-component-main

Abdallah Shalat•220
@abdmosh2000
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi Abdallah, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
    • Replace the <div > containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
    • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
    • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Abdallah Shalat•220
    @abdmosh2000Posted about 2 years ago

    @correlucas Thank you for your constructive criticism of the first challenge. I hope to continue like this. I will review all my mistakes, but I only have 3 screenshots left. I will provide them for the near future. Haha, I appreciate your interest in me and I really hope to find someone like you in my working life

    0
  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @abdmosh2000 👋, good job for completing this challenge and welcome to the Frontend Mentor Community! 🎉

    Here are some suggestions you might consider:

    • The color of the paragraph element is unreadable because it is too light compared to its background, change the color to hsl(220deg, 15%, 55%) for example.

    • Try to use semantic tags in your code. More information here:

    With semantic tags:

    <body>
   <main class="card">
      . . .
   </main>
<body>

    • Use margin: 0.938rem or margin: 15px in the .card selector so that it has some space when viewed on mobile devices.

    • Add a <h1> tag in your solution, The <h1> element is the main heading in a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels; always start from <h1>, followed by <h2> and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference). It also removes some <p></p> tags with no content in the code

    Solution:

    <h1>Improve your front-end skills by building projects</h1>

    I hope those tips will help you.

    Good Job and happy coding !

    Marked as helpful
    0
    Abdallah Shalat•220
    @abdmosh2000Posted about 2 years ago

    @MelvinAguilar Thank you for your constructive criticism of the first challenge. I hope to continue like this. I will review all my mistakes, but I only have 3 screenshots left. I will provide them for the near future. Haha, I appreciate your interest in me and I really hope to find someone like you in my working life

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord