qr-code-component-main

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Ehsan, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • set width: 22rem to main-container class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  1

  ---

  

  Ehsan Qasimi•460

  @ehsanqasimiPosted over 2 years ago

  @denielden noted sir. thanks for the useful advices

  1