Qr_Code_Component_Main

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 2 years ago

  Heyo,

  Your solution looks good! There are some instances where you could follow best practices:

  1. Your image is missing alt text. All images must have one, even decorative ones. In that case you can just leave it empty.

  2. It' s a good idea to have a landmark in your solution. Not essential when you're just working on a component but it's a good habit to get into early on. Just wrap everything in a <main> tag, that should do it.

  3. Don't give your container a height, it's not necessary. In some cases, giving height to elements can even cause an unwanted overflow. Every html element has some default height. To increase this, just add some padding. There are some exceptions to this, of course. You can give you body a min-height if you only have one component to center and you're using flexbox/grid to achieve that. In this case a min-height: 100vh would be the best (no need to use calc or anything like that). Margin is also not needed really on the body.

  4. You could make the component more responsive by switching the width to max-width.

  I hope this helps. Good luck!

  Marked as helpful

  1