qr-code-component-main

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi hmadamk,

  Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:

  • In my opinion, the image is an important content. The alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor not describes the image.

  The markup might look like this:

  <main>
  <div class=”card”>
  <img>
  <h1></h1>
  <p></p>
  </div>
  </main>
  

  hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Ahmed Kamel•1,190

  @hmadamkPosted about 2 years ago

  @PhoenixDev22 Thanks very much this is very obvious but I missed it thank you again

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  Hello HMADAMK, congratulations for your new solution!

  I saw your code and I found a litte mistake, look this line <h1><img src="images/image-qr-code.png" alt="the QR"></h1> maybe this is mistyped but you cannot import the image inside the h1 because this gets confusing the markup.

  Hope this helps, happy coding!

  0

  ---

  

  Ahmed Kamel•1,190

  @hmadamkPosted about 2 years ago

  @correlucas Well you might be right but this time its totally okay to put images inside of h1 and the alt text become your page main heading and it's good for screen readers since this page doesn't have an obvious heading

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @correlucas

  I don’t agree what you’re saying: can please explain how it confuses the markup?

  You can check W3C website . It is valid to use an <img> inside an <h1>.

  1