Design comparison
SolutionDesign
Solution retrospective
I'm unsure about the size (width) of the page and whether I had to include my name in there.
Community feedback
- @jrleijnsePosted almost 2 years ago
Hey there! Great job completing your first challenge! 🎊
I have some suggestions for your code that might interest you.
HTML 📄:
- Instead of using the
<div>tag for your containers, try using some semantic HTML to provide more meaning to it, for better SEO. For example, instead of using<div>you could use the<main>or<section>tag. For the element with the classname attribution you could use the<footer>tag. - If an
<img>like in this case the QR-code, leads to a website or links to someplace else, try to provide a more descriptive text of that in yourALTtext, for example: QR code that leads to frontendmentor.io
CSS 🎨:
- To make your project more responsive and adaptable (in this case as well: especially when you start building bigger and bigger projects), I would suggest to use rem instead of px or other unites. This basically means that all sizing will be calculated in relation to the root element (rem). To set the standard font-size for the root element, you can provide a font-size inside the HTML element inside your CSS. For example:
html {font-size: 15px;}.
For more information on this topic, you can read the following article: PX or REM in CSS? 📘
- An easy way to quickly and automatically center your
<main>element inside the<body>of your page, is by setting the following properties onto the<body>element inside your CSS like so:body { min-height: 100vh; display: flex; flex-direction: column; justify-content: center; align-items: center; }
I hope you find my suggestions useful! The solution you provided is very good!
Keep it up and happy coding! 😃
Marked as helpful1@MichaelAgyebengPosted almost 2 years ago@jrleijnse Thank you very much. Your very thoughtful remarks will help me improve upon my skills
0 - Instead of using the
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord