Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-component-main

@AshwinKumar0

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Started newbie Challenges using html and css only

Community feedback

Joachim 840

@Thewatcher13

Posted

HTML

  • There should be a main element in your html
  • Never skip headings, there can't be a h2 if there is not first a h1 (headings in html are not used for style, just for importance of an element, bigger, bolder styles should be included in your css)
  • Your image alt is empty, don't forget this, it's important.
  • Too much and not useful div's

CSS

  • Your css should be in a seperate file, not in the html file.

  • Don't use id's in css, id's are difficult to overwrite, your specificity should be as low as possible, best practice is to use classes in css

  • Your font-size should never be a px unit, but rem unit. https://fedmentor.dev/posts/font-size-px/

  • Use a css reset, look on Andy's bell website for a good and modern one.

  • You should start mobile first, don't use media queries for mobile first, but for tablet and desktop. (also, use rem instead of px and a min-width instead of max-width.)

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord