QR-code-component-challenge

Community feedback

• 

  Kacper Kwinta•1,405

  @kacperkwintaPosted almost 3 years ago

  Hi (:

  Looks nice

  Some tips:

  • create <main> tag and wrap all other into this (semantic and accessibility), more about this here

  • in <h2>Improve your front-end skills by building projects</h2> you should use h1 tag

  Marked as helpful

  0

  ---

  

  Ahmed Elhebir•20

  @Ahmed-ElhebirPosted almost 3 years ago

  @kacperkwinta Hi (:

  Thanks (:

  These tips really helped me a lot thanks specially when I read about the semantic and accessibility

  0
• 

  Sadiq1029•30

  @Sadiq1029Posted almost 3 years ago

  Bit more padding would make the design more legible

  0

  ---

  

  Ahmed Elhebir•20

  @Ahmed-ElhebirPosted almost 3 years ago

  @Sadiq1029 Hi (:

  Thanks for checking my solution (:

  I have some question because I didn't get it clear:

  Where should I use padding to make the design legible ? And will it be good to use margin instead padding ?

  0

  

  Sadiq1029•30

  @Sadiq1029Posted almost 3 years ago

  @Ahmed-Elhebir apply padding/margin around the image

  0

  

  Ahmed Elhebir•20

  @Ahmed-ElhebirPosted almost 3 years ago

  @Sadiq1029 I'll work on that more and I will see the results 😊

  0