qr-code-component-challange

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hello Soles, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0

  ---

  

  soles•40

  @loicsolbesPosted about 2 years ago

  @denielden thanks for the help ! I will try to apply your advice for the next challenge.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @loicsolbes you are welcome and keep it up :)

  0