Qr-code-component

Community feedback

• Account deleted

  Nice work ✨ Congratulations

  here are some suggestions for you:

  • try to replace the component with modern ways like grid or flexbox
  • decrease padding of the component (the card)
  • decrease the text's padding-top
  • use HTML5 semantic tags like <main> , <section> instead of <div> tags

  Good luck in the next 🔥, keep going on

  1

  ---

  

  Goran Malić•260

  @floatingPebblePosted over 1 year ago

  @MasterMousa

  Everything you said plus border-radius on the image.

  Happy developing to both of you. Cheers!

  1

  Account deleted

  @floatingPebble you're right, I didn't notice it

  happy developing 😊

  1
• 

  khushboo khatwani•1,070

  @khushi0909Posted over 1 year ago

  1. image should always have alt="some description". some description about image should always be there for accessibility reasons

  2)container is not in the center as required by the design ,you should make it center by using flexbox or transform properties reead more about it

  3)Responsiveness has some problem ,if i check this in mobile size of 320 px qr code goes out of the container ,in this context you can also read more about the media queries

  All the best

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h2> so it can cause severe accessibility errors due to incorrect usage of level-two headings <h2>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h2> element which is this <h2>Improve your...</h2>, you can preferably use <h1> instead of <h2>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0