QR-code-component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Jhan, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the figure container of image
  • remove height from .card-container class
  • to make it look as close to the design as possible set width: 22rem to card-container class
  • remove height from img or qr code
  • instead of using px or % use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Jhan! 👋

  Congratulations on completing this challenge! 🎉 Good effort on this challenge! 👍

  There are some areas that can be done better.

  • This site doesn't require any media query in order to be responsive. Here's some guidance to achieve that.
    • First, the card only needs a max-width. Use either px or rem.
    • Second, let the element inside the card dictate the height of the card.
    • Lastly, you can remove the width and the height from the .card-container
  • The image is the main content of the page. It should be visible to screen reader users. Add alternative to the image.
  • It would be great if the site have a title. 😉

  I hope you find this information beneficial. Happy coding! 😄

  0