QR-code-component

Community feedback

• 

  RabicaTahir•500

  @RabicaTahirPosted over 1 year ago

  Hi 👋 zohaib. Congratulations on completing the challenge !

  I have some suggestions about your code.

  HTML⚡:

  ▪ It is advisable that you place all your main site content in a landmark element <main>.

  ▪ Replace <h2> with <h1> it is better to use a tag in sequence.

  ▪ Instead of using br you should use a semantic HTML element and the CSS margin or padding properties if necessary.

  Alt text 🌈:

  ▪ The alt attribute should explain the purpose of the image. so try to use it in image tag.

  CSS 🎨:

  ▪ Instead of using pixels in font-size, using relative units like em or rem is a good practice.

  I hope you find it useful! By the way, the solution was great. 🙌💯

  Enjoy coding, Stay Safe!🤞

  Marked as helpful

  1

  ---

  

  zohaib•80

  @zohaibAlam840Posted over 1 year ago

  @RabicaTahir Thanks for the feedback! I will definitely take it into account in my next challenges!

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • Your solution generates accessibility error reports due to non-semantic markup

  ---

  • So fix it by replacing the <div class="container"> with semantic element <main> to improve accessibility and organization of your page.

  ---

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have values in alt attribute. The alt attribute should explain its purpose. e.g. alt="QR code to frontendmentor.io"

  ---

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  1

  ---

  

  zohaib•80

  @zohaibAlam840Posted over 1 year ago

  @AbdulKhalid Thanks for the feedback! I will definitely take it into account in my next challenges!

  0