Design comparison
Solution retrospective
My second little project. I will be glad if you comment.
Community feedback
- @correlucasPosted about 2 years ago
👾Hi @CharlesSquirel, congratulations on your solution!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
1.Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary
<div>
. For this solution you wrap everything inside a single block of content using<div>
or<main>
(better option for accessibility) and put inside the whole content<img>
/<h1>
and<p>
.<body> <main> <img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" > <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> </body>
2.Use relative units like
rem or em
instead ofpx
to have a better performance when your page content resizes on different screens and devices.REM
andEM
does not just apply to font size, but all sizes as well. To save your time you can code your whole page usingpx
and then in the end use a VsCode plugin calledpx to rem
to do the automatic conversion or use this website https://pixelsconverter.com/px-to-remHere's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
✌️ I hope this helps you and happy coding!
Marked as helpful1 - @Raja-JunaidPosted about 2 years ago
Hello KAROL!
Congratulation on completing this challenge! I really like your solution. Let me give you a few tips to improve your design:
-
When designing your website keep your work decent.
-
Use Frameworks.
-
Use decent colors and keep your website neat and clean.
-
Use nice-looking Fonts.
Keep Coding and Keep Practicing.
HAPPY CODING!
0@CharlesSquirelPosted about 2 years ago@Raja-Junaid I've got fonts and colors from figma's file, so I didn't have to choose. I didn't have to design anything.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord