Skip to content
Submitted about 2 years ago

QR-code-component with Flexbox

Karol•260
@CharlesSquirel
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

My second little project. I will be glad if you comment.

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hi @CharlesSquirel, congratulations on your solution!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    1.Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    2.Use relative units like rem or em instead of px to have a better performance when your page content resizes on different screens and devices. REM and EM does not just apply to font size, but all sizes as well. To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
    Karol•260
    @CharlesSquirelPosted about 2 years ago

    @correlucas Thanks for your very helpful advices. For such comments I’ve choosen frontendmentor.

    0
    Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    @CharlesSquirel you're welcome Karol, keep posting amazing solutions ✌️

    0
  • Corey•90
    @cjay44Posted about 2 years ago

    Looks Great!

    0
  • Raja Junaid Farooq•390
    @Raja-JunaidPosted about 2 years ago

    Hello KAROL!

    Congratulation on completing this challenge! I really like your solution. Let me give you a few tips to improve your design:

    1. When designing your website keep your work decent.

    2. Use Frameworks.

    3. Use decent colors and keep your website neat and clean.

    4. Use nice-looking Fonts.

    Keep Coding and Keep Practicing.

    HAPPY CODING!

    0
    Karol•260
    @CharlesSquirelPosted about 2 years ago

    @Raja-Junaid I've got fonts and colors from figma's file, so I didn't have to choose. I didn't have to design anything.

    0
    Raja Junaid Farooq•390
    @Raja-JunaidPosted about 2 years ago

    @CharlesSquirel OK!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord