Submitted 8 months ago

qr-code_component

Wolfgang Schulz• 30

@Wolle3008

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I already finished this project before, just had to submit the solution again for the path progress. So i just changed the everything was wrapped in to to make in more semantic.

What challenges did you encounter, and how did you overcome them?

Just had to update to follow the path.

What specific areas of your project would you like help with?

Just had to update to follow the path.

Community feedback

Daniel 🛸• 44,230

@danielmrz-dev

Posted 8 months ago

Hello @Wolle3008!

Your solution looks great!

I have a suggestion for improvement:

Use <main> to wrap the main content instead of <div>.

📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

Wolfgang Schulz• 30

@Wolle3008

Posted 8 months ago

@danielmrz-dev

Thank you very much for the advice. I just changed it as well for my second project i just finished right now. I did the same thing there as well, but just changed it before submitting it.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord