Skip to content
Submitted almost 2 years ago

QR-code-component

Earl Villapaz•80
@iEarlG
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What did you find difficult while building the project?

  • Styling the image and putting the text above and below the image Which areas of your code are you unsure of?
  • The responsiveness of the website not sure if I did it correctly. Do you have any questions about best practices?
  • Feel free to put an issue on the repo for this project on the github, I will appreciate any feedback coming from mentors.

Community feedback

  • Vanza Setia•27,775
    @vanzasetiaPosted almost 2 years ago

    Hi, Earl Villapaz! 👋

    For the image styling, make the <img> as a block element and set max-width: 100%. It makes working with <img> easier.

    You should put the attribution after the card. The attribution should be wrapped by <footer> instead of <header>. The main content should go first, then your attribution.

    The alternative text of the QR code should describe the purpose of the QR code. It should not be hyphenated like class names. It should be human-readable.

    I hope this helps.

    Marked as helpful
    0
    Earl Villapaz•80
    @iEarlGPosted almost 2 years ago

    @vanzasetia Thankyou, I will keep this in mind and apply it on the project later today

    0
    Vanza Setia•27,775
    @vanzasetiaPosted almost 2 years ago

    @iEarlG

    You are welcome! Good luck with it! 👍

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord