qr-code-component using HTML and CSS

Community feedback

• 

  Adebisi•350

  @adebisiabdussamadPosted almost 2 years ago

  Cheers 🥂 on completing this challenge.. .

  An img element must have an alt attribute. This enables physical challenge to understand the image better. -This is your code:<img src="./images/image-equilibrium.jpg">

  -This is how it should be:<img src="./images/image-equilibrium.jpg" alt="">the second one with the alt attritube your code is really amazing...hope you find this helpful... Happy coding!!!👌👍

  Marked as helpful

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Adeyinka, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • img element must have an alt attribute, it's very important!
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • remove all margin from .square class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh and margin: 0 to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  0