QR-Code-Component using HTML and CSS

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  HTML

  In order to fix the accessibility issues:

  • You need to replace <div class="container"> with the <main class="container"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you should use one <h1> element in the <main> tag. You can replace your <h4>Improve your front-end skills by building projects</h4> element with the <h1>Improve your front-end skills by building projects</h1> element.

  After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

  CSS

  • If you want to center it correctly, you can use flexbox and min-height in the body:

  body {
    -ms-text-size-adjust: 100%;
    -webkit-font-smoothing: antialiased;
    -moz-osx-font-smoothing: grayscale;
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
    background-color: var(--clr-secondary);
    font-family: "Outfit", sans-serif;
  }
  

  • after using flexbox, you need to remove html in CSS and remove the margin from .container

  /* html {
    font-family: "Outfit", sans-serif;
    background-color: var(--clr-bg);
    margin: 0;
  } */
  
  .container {
    display: flex;
    flex-direction: column;
    align-items: center;
    width: 15rem;
    /* margin: 0 auto; */
    background-color: var(--clr-body);
    border-radius: 0.8rem;
    /* margin-top: 4rem; */
    /* margin-bottom: 4rem; */
    padding: 0.5rem;
  }
  

  Hope I am helpful. :)

  Marked as helpful

  1
• 

  Bader Idris•2,880

  @Bader-IdrisPosted over 1 year ago

  You can set the container in the middle of the screen whatever user changes it when you add these property values to it in CSS: .container { display: absolute; top:50%; left: 50%; transform: translate(-50%, -50%); } the feature that might be new is transform, it has many lovely property values you can discover, I personally love it

  Marked as helpful

  1
• 

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  I have recommendations regarding your code that I believe it will great interest to you.

  HTML: This solution generates accessibility error reports. So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page. You should replace h4 tag to h1 tag inside your main tag.

  I hope you find this helpful.

  Happy coding!

  Marked as helpful

  0