@ecemgo
Posted
Some recommendations regarding your code that could be of interest to you.
HTML
In order to fix the accessibility issues:
- You need to replace
<div class="container">
with the<main class="container">
tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly. - Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you should use one
<h1>
element in the<main>
tag. You can replace your<h4>Improve your front-end skills by building projects</h4>
element with the<h1>Improve your front-end skills by building projects</h1>
element.
After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.
CSS
- If you want to center it correctly, you can use flexbox and min-height in the
body
:
body {
-ms-text-size-adjust: 100%;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
min-height: 100vh;
background-color: var(--clr-secondary);
font-family: "Outfit", sans-serif;
}
- after using flexbox, you need to remove
html
in CSS and remove themargin
from.container
/* html {
font-family: "Outfit", sans-serif;
background-color: var(--clr-bg);
margin: 0;
} */
.container {
display: flex;
flex-direction: column;
align-items: center;
width: 15rem;
/* margin: 0 auto; */
background-color: var(--clr-body);
border-radius: 0.8rem;
/* margin-top: 4rem; */
/* margin-bottom: 4rem; */
padding: 0.5rem;
}
Hope I am helpful. :)
Marked as helpful