Skip to content
Submitted about 2 years ago

qr-code-component using css

Indra Saputra Idrus•210
@IndraSaputraIdrus
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hi @IndraSaputraIdrus, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    Something I've noticed in your code is that on many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, which can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    0
    Indra Saputra Idrus•210
    @IndraSaputraIdrusPosted about 2 years ago

    @correlucas Thank you so much for the advice

    0
  • Funsho Ayobanjo•150
    @ayobanjoPosted about 2 years ago

    Hi @IndraSaputraIdrus Good job on your first project, lovely

    The only observation I have is that for mobile responsiveness, you should use a max-width instead of width on the card div

    max-width : 260px or its equivalent in rem

    0
    Indra Saputra Idrus•210
    @IndraSaputraIdrusPosted about 2 years ago

    @ayobanjo thank you for the tips

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord