Skip to content
Submitted 7 months ago

Qr-code-component

mircodev•60
@mircodg
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Proud that I found some spare time to start and finish this challenge. I learned a lot while having some fun. Surely I need to learn and practice media queries.

What challenges did you encounter, and how did you overcome them?

Positioning things in the right place can be difficult at times but with the developer tools and googling everything can be fixed.

What specific areas of your project would you like help with?

Any feedback is appreciated.

Community feedback

  • Bernardo Poggioni•5,360
    @R3ygoskiPosted 7 months ago

    Hello @mircodg, congratulations on completing your first project here on Frontend Mentor, it turned out well.

    If you want to make it closer to the proposed design, you can decrease the width to something close to 310px, and decrease the font size of the <h1>.

    Now, a tip about fonts in CSS, try to always use the unit rem, as it is relative and adapts to the user's font settings, which helps with responsiveness and accessibility on your page.

    Another tip is about HTML, it's well-structured, but lacks a bit in semantics. If you want to make it more semantic, you can, for example, replace <div class="container" role="main"> with <main>. Although role="main" can be used as an alternative, it doesn't replace the semantic aspect of <main>.

    Again, congratulations on the solution, keep practicing and improving. If you need help with any part, please comment below.

    Marked as helpful
    0
    mircodev•60
    @mircodgPosted 7 months ago

    Thank you so much for the feedback! @R3ygoski

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord