@R3ygoski
Posted
Hello @mircodg, congratulations on completing your first project here on Frontend Mentor, it turned out well.
If you want to make it closer to the proposed design, you can decrease the width
to something close to 310px, and decrease the font size of the <h1>
.
Now, a tip about fonts in CSS, try to always use the unit rem, as it is relative and adapts to the user's font settings, which helps with responsiveness and accessibility on your page.
Another tip is about HTML, it's well-structured, but lacks a bit in semantics. If you want to make it more semantic, you can, for example, replace <div class="container" role="main">
with <main>
. Although role="main"
can be used as an alternative, it doesn't replace the semantic aspect of <main>
.
Again, congratulations on the solution, keep practicing and improving. If you need help with any part, please comment below.
Marked as helpful
@mircodg
Posted
Thank you so much for the feedback! @R3ygoski