Design comparison
Solution retrospective
Hi, this is my first challenge I'm submitting here! Would love any feedback particularly regarding naming conventions in HTML as well as grouping the styles of elements in my stylesheet. Trying to name that tune with as few lines as I can but wanted to get something up here finally!
Community feedback
- @perezjprz19Posted almost 3 years ago
Hi Morgan!
I think your solution looks good. There wasn't a lot to really practice a naming convention in this one. However, if working on a larger project with multiple containers or info pieces, your naming conventions might be a little generic and could cause a headache later. BEM seems pretty popular, so I 'd look into that, but there other naming conventions too.
As far as the grouping, I've tried a couple of things in the past. Generally, I do like to just follow the outline of the HTML, as you did, so I don't see a problem with that. Grouping all components together (such as buttons) and all containers etc., was just a lot of back and forth for me and not worth the hassle.
With that being said, I'm still looking for something that feels natural and is less messy. Until then, I'm going to keep trying new things while I can.
For this one, I'd just suggest going through your error report to clear it.
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord