Design comparison
Community feedback
- @Kamlesh0007Posted over 1 year ago
Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to add Semantic HTML tags
The HTML structure should be semantically correct. The current structure doesn't provide any semantic information about the content. A better approach would be to use appropriate HTML tags such as <header>, <main>, <section>, <article>, etc. to define the sections of the page.and also use h1 instead of h3 tag because Heading elements provide a hierarchical structure to the content, indicating the importance and structure of the headings within the page. The <h1> element represents the main heading of the page, typically the title or primary heading that sets the overall context. It carries the highest level of importance and is often used only once per page. On the other hand, <h3> represents a lower level of heading, typically used for subheadings within sections or subsections of the content.
here is the code that u need to add to add semantic tags in ur page
<body> <main> <div class="container"> <div class="card"> <div class="img"> <img src="./images/image-qr-code.png" alt="qr-image"> </div> <div class="title"> <h3>Improve your front-end skills by building projects</h3> </div> <div class="paragraph"> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </div> </div> </div> </main> </body>0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord