QRcodecomponent

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="container"> instead of <div class="container">.

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  0

  ---

  

  David Teixeira•90

  @DavesTicTeixeiraPosted over 2 years ago

  @Samadeen Hey thank you for the feedback. I should pay more attention to semantics.

  0
• 

  IRVINE MESA•1,855

  @DrMESAZIMPosted over 2 years ago

  Hi David

  I do have some suggestions which I would like you implement to make this solution better

  1. inside the file style.css on line 7 set

  .container { background-color: hsl(0, 0%, 100%);}

  2.inside the file style.css on line 36 add

  body{ background-color: hsl(212, 45%, 89%); }

  Marked as helpful

  0

  ---

  

  David Teixeira•90

  @DavesTicTeixeiraPosted over 2 years ago

  @DrMESAZIM Ok I see it. Made the change thanks for the fb, apriciated.

  0