Submitted almost 2 years ago

qr-code-component

Gomen•120

@Leviakc

Preview site View code

This is a solution for...QR code component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

qr code component

My first practice in frontendmentor, at first it was a little complicated not for the coding part but for naming classes, choosing which unit should I use, etc.

I hope to gain more confident and knowledge about web devepolment

edit: I did some changes, any feedback will be more than welcome!

Community feedback

Melvin Aguilar 🧑🏻‍💻•61,140
@MelvinAguilarPosted almost 2 years ago
Hello there 👋. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

CSS 🎨:

Consider using BEM naming conventions for your CSS classes.

Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this two lectures:

1. The Surprising Truth About Pixels and Accessibility - The 62.5% trick.

2. A comment on the 62.5% trick.

Credit to grace-snow and vanzasetia for pointing this out.

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!
Marked as helpful
2
Gomen•120
@LeviakcPosted almost 2 years ago
@MelvinAguilar Thank you! Honestly didn't thought the 62.5% trick had some compatibility issues, your response was indeed very helpful and thaks again.
1

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord