Qr-code-component

Community feedback

• 

  Tom•120

  @l3lazePosted 12 months ago

  This looks awesome, and the animations are a great touch. I didn't expect them, so after I moused over it I had to mess around for a moment to explore. Lol. I also like that you used grid; I've been having a lot of difficulty getting that, and was hoping to see it used on this project. Are there any links you could share to help gain a better understanding of grid usage?

  The only issue I can see is not having consistent formatting for readability. A lint tool or formatter would help.

  HTML

  • `` tag is indented.

  ---

  CSS

  • Excessive selectors, e.g. h1, h2, h3, h4, h5, h6.

  • Capitalization on Font-size.

  • Inconsistent whitespace throughout: between selectors and opening brace ({), between blocks (both excessive newlines and lack of newlines), between property and value (prop: value with more than 1 space), between end of declaration and ending semicolon (;).

  Marked as helpful

  0
• 

  atooool•170

  @atulpalkar16Posted 12 months ago

  Thank you for reviewing my solution and offering valuable tips. I found Kevin Powell's tutorial on youtube , 'Learn CSS Grid the easy way' very helpful in resolving several of my doubts regarding CSS Grid."

  0