Skip to content
Submitted about 2 years ago

qr-code-component

Anointed Kayode•420
@Coderio10
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

So, check it out!

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hello @Coderio10, Congratulations on completing this challenge!

    Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

    1.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

    To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem here's the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

    2.Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Anointed Kayode•420
    @Coderio10Posted about 2 years ago

    @correlucas Thanks

    1
  • Santiago Moraga Caldera•710
    @Remy349Posted about 2 years ago

    Everything looks amazing, just a little tip for the <h1> element. Try adding some left and right margin, and try changing the font size, 1.3rem should be enough to make it look the same as the challenge.

    Marked as helpful
    0
    Anointed Kayode•420
    @Coderio10Posted about 2 years ago

    @Remy349 thanks

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord