QR-code-Component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Joshua W,

  I have some suggestions regarding your solution , if you don't mind:

  HTML

  • You should use <main> for the card and <footer> for the attribution . Landmarks allow screen reader users to navigate through sections of your website by skipping to content that interests them. Landmarks could be seen as the logical layout of the website's UI, which is divided into e.g. header, navigation, main content, and footer. So the usage makes sense in any case.

  • In my opinion, the image is an important content. The alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor not describes the image.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute, you can expose your site to performance and security issues.

  Last , after you fix the accessibility issues , you can generate another report for your solution.

  Great work overall, Hopefully this feedback helps

  Marked as helpful

  0