QR-code-component

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have a suggestion regarding your code that I believe will be of great interest to you.

EFFECTIVE USAGE OF FLEXBOX:

• Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

• We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

• You already using Flexbox for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.

body {
  justify-content-center;
}

• Now remove these styles, after removing you can able to see the changes

.container {
  margin: 0 auto;
}

• Now your component has been properly centered

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Hi @sonnuuuu,

Nice Work !

I would suggest following:-

1.<div class="container"> is redundant.

2.Prefer replacing <div class="card"> with <main> element.

3.Prefer replacing <h2> with <h1> element.

These will improve accessibility and make your markup more semantic.

Hope these suggestions are helpful !

Stay Happy & Well !

Happy Learning !