qr-code-component

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey Maria,

  My suggestions:

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="card">
        //...
     </div>
  </main>
  

  • Page should contain a level-one heading, Change h to h1(There is no element called h) You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page. There are six levels of section headings <h1> to <h6>

  • All page content should be contained by landmarks, Contain the attribution with <footer>.

  <footer>
     <div class="attribution">
        //...
     </div>
  </footer>
  

  Hope this help!... Keep it up👍

  1
• 

  Maria•130

  @maaghiaPosted over 2 years ago

  Your comment helped me understand the way accessibility issues should be handled I will take this into consideration thank you.

  0