Design comparison
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hello π. Congratulation on successfully completing your first challenge π ! !
I have some recommendations regarding your code that I believe will be of great interest to you.
Alt text π·:
-
The
alt
attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteralt
attribute would beQR code to frontendmentor.io
If you want to learn more about the
alt
attribute, you can read this article. π.
CSS π¨:
- The
width: 100%
property in thebody
tag is not necessary. Thebody
tag is a block element and it will take the full width of the page by default.
- Use
min-height: 100vh
instead ofheight: 100vh
andheight: 100%
. Theheight
propertys can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 -
- @HassiaiPosted almost 2 years ago
Replace <h2> with <h1> to fix the accessibility issue.
There is no need to give the body a width and height value. Give the background-color you gave to the main to the body.
To center .container on the page using flexbox, replace the height in the main with min-height: 100vh.
There is no need to give #qrImg a padding value, reduce the border-radius value and replace the width with a max-width.
Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord