Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-code-component

Diozizo 40

@Diozizo

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@tburette

Posted

A fine solution. The result matches the challenge.

The html/css does the job. The remarks below are more nitpick than anything else.

In the html I noticed you put a random amount of newlines between the container and the attribution.

Instead of margin-left: auto; margin-right: auto; you could have done margin-inline: auto;. Another possibility would have been /* top | left and right | bottom */ margin: 0 auto 1.3rem; but that's not necessarily very readable..

Having custom properties start with an uppercase is unusual.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord