QR-code-component

Community feedback

• 

  Thomas Burette•190

  @tburettePosted 10 months ago

  A fine solution. The result matches the challenge.

  The html/css does the job. The remarks below are more nitpick than anything else.

  In the html I noticed you put a random amount of newlines between the container and the attribution.

  Instead of margin-left: auto; margin-right: auto; you could have done margin-inline: auto;. Another possibility would have been /* top | left and right | bottom */ margin: 0 auto 1.3rem; but that's not necessarily very readable..

  Having custom properties start with an uppercase is unusual.

  Marked as helpful

  0