Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-component

Nikhil Padwalβ€’ 10

@nikhilxpadwal

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


No didn't find any difficult while building the project

Community feedback

Hamid Mahmoodβ€’ 540

@Hamid210545

Posted

Hello ..... you have done an amazing job.... but let me correct you ... your card is not in center of the screen as per as design requirements.... but you can fix it by taking one simple step: by setting the properties of body tag { display: flex ; justify-content: center ; align-items: center ; } ............... I hope this will fix your problem............ Thanks!

0

@MelvinAguilar

Posted

Hi @nikhilxpadwal πŸ‘‹, good job on completing this challenge, and welcome to the Frontend Mentor Community! πŸŽ‰ **

I like this solution for the challenge. I have some suggestions you might consider to improve your code:

  • Your solution should contain a title tag with the name of the challenge and an icon.
<title>Frontend Mentor | QR code component</title>
<link rel="icon" type="image/png" sizes="32x32" href="./favicon-32x32.png" />
  • To make alternative texts more useful, add descriptive text to the alt attribute of the QR image to explain what the QR image does.

  • Add an h1 tag to your solution. The <h1> element is the main heading on a webpage, also, there should only be one <h1> tag per page.

<h1 class="...">Improve your front-end skills by building projects</h1>

I hope those tips will help you! πŸ‘

Good job, and happy coding! 😁

0
Adrianoβ€’ 34,090

@AdrianoEscarabote

Posted

Hi Nikhil Padwal, how are you?

Welcome to the front-end mentor community!

I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

Example:

body {
    margin: 0;
    padding: 0;
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
}

The rest is great!

I hope it helps... πŸ‘

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord