QR-code-component for the practice of Basic HTML&CSS

Community feedback

• 

  Pritam Panda•60

  @imxeonPosted 5 months ago

  First thing - remove the attribution from the bottom of the card, the goal is to make similar or exact design to the reference. The reference design does not contains it.

  1. The solution does not include semantic elements. Include elements like main, section instead of using div everywhere for better accessibility.

  2. It is recommended to use lowercase for CSS selector names. Replace the capital H in this line <div class="Heading"> with lowercase h.

  3. You should use the type selector h2 directly in the stylesheet to target the element instead of using inline styling - <h2 style="padding:0;margin:0;display:flex;">Improve your front-end skills by building projects</h2> this will result is better readability of the code.

  1

  ---

  

  MrOsamashahid•30

  @MrOsamashahidPosted 5 months ago

  @imxeon thank uh so much for the guidance pls check more flaws and also gimme tips

  0