Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-code-component

@amootkiiza22

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Building this project was not easy though it looks simple especially the css section any feedback is welcome

Community feedback

JimTK16 370

@JimTK16

Posted

Hi Kiiza,

Nice project :) . In terms of CSS, i think you can remove heigth:100% and width:100% on the body since it's not necessary. You can try to toggle these properties in the devtool to see what changes they make. Also, we should avoid setting a fixed width in general. Like you can set a max-width: 375px on your .card instead of width:375px, it allows room for responsiveness. Same to images, instead of fixed width and height, you could do something like this img {display:block; max-width:100%}. Hope it helps!

Jim

0

@amootkiiza22

Posted

Thank brother for pointing some good information about my CSS I will not repeat those mistakes again.@JimTK16

1

@amootkiiza22

Posted

Thank brother for pointing some good information about my CSS I will not repeat those mistakes again.@JimTK16

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord