Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-code-component

@Sebascode20

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All feedback is welcome, thank you in advance.

Community feedback

@dimar-hanung

Posted

Hello 👋, Well done on completing the challenge! 🎉

I have some interest and feedback with your code

That i like:

  1. I appreciate the similarity of your results with the design, a bit different in position and font because footer, but still good 👐
  2. 📁 Folder is well structured, i like it
  3. html is pretty good, not too nested 👍
  4. CSS Naming is also good, represent what is it for, like <div class="card"> for card section
  5. Responsive until galaxy fold screen size 👌

My Feedback:

  • You can make it center by adding min-height and remove set margin:0 to fix overflow, make body styles into this

    body {
      font-size: 15px;
      font-family: "Outfit", sans-serif;
      background-color: hsl(212, 45%, 89%);
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      
      margin: 0;
      min-height: 100vh;
    }
    

anyways overall is good, nice solution, hope it useful 🙌

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord