Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-Code-Component | Desktop/Mobile Design

Shubham Guptaβ€’ 110

@shubhamgupta0720

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! :) This is my solution to QR-Code-Comonent Challenge, which was created in HTML and CSS! Do like my solution and any feedback from you will be appreciated!

Thanks!

Community feedback

Daniel πŸ›Έβ€’ 44,230

@danielmrz-dev

Posted

Hello @shubham0720!

Your solution looks great!

I have a suggestion for improvement:

  • Use <main> to wrap the main content instead of <section>.

πŸ“Œ The tag <section> would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

1

Shubham Guptaβ€’ 110

@shubhamgupta0720

Posted

@danielmrz-dev Thanks for the inputs! I really appreciate taking out your time to review my code and analyzing my design and I will keep them in mind.

Cheers!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord