QR-Code-Component | Desktop/Mobile Design

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @shubham0720!

  Your solution looks great!

  I have a suggestion for improvement:

  • Use <main> to wrap the main content instead of <section>.

  📌 The tag <section> would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

  This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  Shubham Gupta•110

  @shubhamgupta0720Posted 9 months ago

  @danielmrz-dev Thanks for the inputs! I really appreciate taking out your time to review my code and analyzing my design and I will keep them in mind.

  Cheers!

  0