@correlucas
Posted
๐พHi @sevvy-thewebcoder, congratulations on your solution!๐ Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw youโre on the right track. Iโve few suggestions for you that you can consider adding to your code:
Your solution is great and the code is working, but the HTML structure can be reduced by removing unnecessary divs, all you need is a single <main>
or <div>
to keep all the content inside, and nothing more. The ideal structure is the div
and only the image, heading, and paragraph.
Hereโs one example to show can be cleaner this HTML structure:
<body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
To reduce the CSS you can use the direct selector for each element instead of using class
this way you have a code even cleaner, for example, you can select everything using the direct selector for (img, h1, and p, main).
Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
โ๏ธ I hope this helps you and happy coding!
@sevvy-thewebcoder
Posted
@correlucas Thank you so much for this valuable code review and your advice ๐
I'll implement these tips in my next projects ๐๐