Design comparison
SolutionDesign
Community feedback
- @MelvinAguilarPosted about 2 years ago
Hi @Lun0xxx 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉
Here are some suggestions you might consider:
- Your page is broken on mobile devices and devices between 376px and 1439px wide.
- There is no need to use media query in this solution.
- The footer should be outside the main landmark.
- Try to use semantic tags in your code. Click here for more information.:
With semantic tags:
<body> <main class="main"> . . . </main> <footer> . . . </footer> <body>- The <div> tag defines a division or section on a website. It is used to style a container with CSS, set special alignment, or position content. It might be more efficient to use the <p> tag; the <p> element represents paragraph-level content, usually text:
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>- Add an h1 tag to your solution. The
<h1>element is the main heading on a web page. There should only be one<h1>tag per page, and always avoid skipping heading levels; Always start from<h1>, followed by<h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)
Solution:
<h1>Improve your front-end skills by building projects</h1I hope those tips will help you.
Good job, and happy coding!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord