QR-code-component

Community feedback

• 

  Saulius K.•560

  @TH3RIVPosted almost 2 years ago

  Hi, @CarolinaVrl!

  Your card looks great! There's only a few suggestions I can make for future improvement:

  • Your attribution should be either wrapped within main tags or footer tags. That way screen readers will have easier time figuring out what it is.
  • Try to avoid using px values and use rem instead.
  • There's no need to declare a fixed with or height for the containers, max-width for the card is enough. The rest can be adjusted with margins or padding on the parent.

  Keep up the good work! Hope this helps!

  Marked as helpful

  1