Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-code-component

@CarolinaVrl

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All Feedback is welcome, thank you.

Community feedback

Saulius K. 560

@TH3RIV

Posted

Hi, @CarolinaVrl!

Your card looks great! There's only a few suggestions I can make for future improvement:

  • Your attribution should be either wrapped within main tags or footer tags. That way screen readers will have easier time figuring out what it is.
  • Try to avoid using px values and use rem instead.
  • There's no need to declare a fixed with or height for the containers, max-width for the card is enough. The rest can be adjusted with margins or padding on the parent.

Keep up the good work! Hope this helps!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord