QR-code-component

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted about 1 year ago

  HTML:

  • The alt text should also describe where scanning the QR code would take you: "QR code that leads to frontendmentor.io"

  • Remove the <br>. You should let the text flow naturally, and remember, all styling should be done in the CSS.

  CSS:

  • Change the body height to min-height.

  • Remove all fixed widths and heights. Except for icons, you rarely want to set fixed dimensions.

  • Remove all the positioning - relative, absolute. You don't need it in this project. And I'm not sure what it is you were trying to do...?

  Good luck :)

  Marked as helpful

  0

  ---

  

  sefat khan•120

  @Sefat-KhanPosted about 1 year ago

  @Islandstone89 thanks for your advise. I'm new here and i'm learning.

  1