Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-code-component

sefat khan 120

@Sefat-Khan

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All Feedback is Down there

Community feedback

P

@Islandstone89

Posted

HTML:

  • The alt text should also describe where scanning the QR code would take you: "QR code that leads to frontendmentor.io"

  • Remove the <br>. You should let the text flow naturally, and remember, all styling should be done in the CSS.

CSS:

  • Change the body height to min-height.

  • Remove all fixed widths and heights. Except for icons, you rarely want to set fixed dimensions.

  • Remove all the positioning - relative, absolute. You don't need it in this project. And I'm not sure what it is you were trying to do...?

Good luck :)

Marked as helpful

0

sefat khan 120

@Sefat-Khan

Posted

@Islandstone89 thanks for your advise. I'm new here and i'm learning.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord