Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr-Code-Component

@UdbhavDalmia

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@francescomerighi1202

Posted

Hi there!

Your solution is partially correct.

I strongly advise against setting fixed heights for this sort of thing.

Center your card by adding 'display: grid', 'place-content: center' and 'height: 100vh'.

One more thing, use specific tags to "explain" what piece of code you are looking at (e.g. <main> <section> etc...)

Try updating your solution after applying the above changes.

Hope I was helpful! In any case, if you need it, you can look at my solution!

P.S. (If you found this comment helpful, please mark it)

0

@UdbhavDalmia

Posted

@francescomerighi1202 what does height: 100vh; means i mean how many pixels or any reference

0

@francescomerighi1202

Posted

@UdbhavDalmia 100vh means 100% of the viewport height

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord