Frontend Mentor | qr-code-component coding challenge solution

Community feedback

@0xabdulkhaliq

Posted over 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

For example:
- The <main> element should include all content directly related to the page's main idea, so there should only be one per page
- The <footer> typically contains information about the author of the section, copyright data or links to related documents.

BODY MEASUREMENTS 📐:

The width: 100% property for body element is not necessary. it will take the full width of the page by default.

Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.

But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

KAMALESH P• 140

@kamalesh0703

Posted over 1 year ago

ok brother next i will correct u@0xAbdulKhalid

@atif-dev

Posted over 1 year ago

Hi kamalesh0703, congrats🎉 on completing the challenge. Better take care about following points.

Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. To avoid accessibility issue "All page content should be contained by landmarks" use code as :

<body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

(why main matters? Read here)

When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
Include a README file in your GitHub project's solution and write about your working flow, findings, new learned things, useful resources, etc.

Hope you will find this Feedback Helpful.

KAMALESH P• 140

@kamalesh0703

Posted over 1 year ago

ok ,I will following your instruction@atif-dev

qr-code-component