Qr-code-component

Community feedback

• 

  Francisco Carrillo•5,540

  @frank-itachiPosted almost 2 years ago

  Hello there 👋. Congratulation for completing the challenge👍!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • If your code has different sections that have a specific purpose like a navigation, article, sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks. For example, you could use a <footer> tag to wrap the <div class=”attribution”> section.
  • The heading order is important in the html structure so try to always start your headings with an <h1> tag and then you can decrease by one if you need to use more heading in your html code.

  CSS 🎨:

  • Avoid using absolute length units like px because they are not relative to anything else so that means they will always be the same size. Instead you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g. the parent container. You can dig up about it here.

  I hope you find it useful! 😄 Above all, you did a good job!

  Happy <coding /> 😎!

  0

  ---

  

  Nwajei Edgar•110

  @OtakuwindPosted almost 2 years ago

  @frank-itachi thank you, I'm still a newbie so pardon my errors. Yourcomment is very helpful and much appreciated.

  0