Design comparison
Solution retrospective
Hi Everyone,
This is my first Frontend Mentor project, and I would really appreciate your feedback 😊
Are there any parts of my code that are not needed or could be simplified (same or better outcome with less code).
Stylesheet - Is my use of widths, correct? The specification provided a desktop and mobile width. I set the width of the .container class to the mobile width (375px), was this the correct approach?
Thank you in advance. Scott
Community feedback
- @correlucasPosted about 2 years ago
👾Hi @Scott-321, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!
Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:
Something I've noticed in your code is that in many occasions you've added some
<div>to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be<div>or<main>if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:<body> <main> <img src="./images/image-qr-code.png" alt="Qr Code Image" > <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> </body>✌️ I hope this helps you and happy coding!
Marked as helpful0@Scott-321Posted about 2 years ago@correlucas Thank you so much! I'm going to try the challenge again using your feedback 👍
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord