qr-code-component

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

• So fix it by replacing the <div class="container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

• What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

• For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

HEADINGS ⚠️:

• This solution has also generated accessibility error report due to lack of level-one heading <h1>

• Every site must want at least one h1 element identifying and describing the main content of the page.

• An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

• So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

SUGGESTION 💡:

• Looks like the image path(src url) is broken, so that the image is not loading in your site. But we can fix the issue right now. Let me explain it

• Here the image path you provided need to be starts with ./ because putting ./ states that your index.html file is in the root directory. So we can quicky fix by adding the ./ infront the image src path.

• Example <img alt="qr-code" src="./images/image-qr-code.png">

• Note: ./ is important here, which states the root of a folder

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!