qr-code-component

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Rakesh Kumar Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body <main class="container"></main>

  -> Recheck the background

  -> Learn more on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  Marked as helpful

  0
• 

  Dinesh Sake•320

  @NrupatunganPosted almost 3 years ago

  Hello Rakesh, congrats on completing your challenge.🎉

  I saw your solution and i recommend you to follow these steps to better your Frontend:

  1. Use Semantic HTML as it gives the content on the page meaning and structure by using the proper element. As regular <div> and <span> elements don’t hold any semantic value. They exist for styling purposes only. check this link for more details click here.
  2. Properly center your container or main-component by using methods like positioning, Flexbox align-items etc. You can search on google on how to center containers.
  3. Use Google fonts for styling your fonts.
  4. Use correct Colors and Typography provided in your style-guide as it will give a great look to your webpage.

  It would help you a lot if you adopt these tips in your upcoming Frontend Challenges.

  Have a great day!!

  Marked as helpful

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Rakesh, congratulations on completing the challenge.

  I had a look at your solution:

  • add main tag and wrap the card for Accessibility
  • try to remove all margin from container and middle-container classes and use flexbox to the body for center the card. Read here -> flex guide
  • also set heigth of body to 100vh because Flexbox aligns to the size of the parent container.

  In the end do not use the css style inline but one of the classes :)

  Overall you did well! Hope this help ;)

  Marked as helpful

  0
• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • Always Use Semantic HTML instead of div like <main> <header> , etc for more info.

  if my solution has helped you do not forget to mark this as helpful!

  Marked as helpful

  0

  ---

  

  Rakesh Kumar•20

  @Rakesh709Posted almost 3 years ago

  @Old1337 yes yes thank you

  1
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great work man, check mine also.

  0
• Account deleted

  Hi there 👋

  Congratulate on finishing your project 🎉. You did a great job 💡

  I give some suggestions to help you take your project design to the next level 📈😉

  • Change the background color to #D5E1EF 🙌
  • They don't family is not imported too, change it to the one as given in the style-guide.md file
  • I'd suggest decreasing the padding in the card also 👍

  Happy coding ☕

  Maqsud

  0