qr-code-component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div id="wrapper"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Mariana Oliveira•10

  @marioli99Posted over 1 year ago

  Olá, gostei bastante do seu projeto porém tenho algumas dicas para aprimora-lo:

  1- seria legal colocar um padding-top:10% no body para ficar mais fiel ao desgn.

  2 - Mudar o background do #wrapper para px pois utilizando rem chega um momento em que o background some pois a imagem continua com a mesma proporção anterior.

  3 - Colocar um footer e distancia-lo do wrapper para ficar uma apresentação mais delicada e bonita.

  4 - dê uma atenção ao style.guide pois a cor do background do body não está condizente com o design.

  0